Project

Profile

Help

Task #6992

Refactor up method

Added by Mark Zaslavskiy over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Alexander Kaluzhny
Category:
mdbci testing
Sprint/Milestone:
Start date:
09.05.2016
Due date:
% Done:

0%

Estimated time:
Target branch:
Test scenario:

Description

mdbci up is a key method for instrument and it should not look like canonical example of spagetti code.
https://github.com/OSLL/mdbci/blob/dfe2af4d3b354ddb322806f9c2ab9b727463bfe5/core/session.rb#L503
Method:
- should be no longer than 34 lines
- all simmilar and duplicated code should be extracted to functions for reuse
- all else blocks after raise and return should be removed
- such https://github.com/OSLL/mdbci/blob/dfe2af4d3b354ddb322806f9c2ab9b727463bfe5/core/session.rb#L651 and such https://github.com/OSLL/mdbci/blob/dfe2af4d3b354ddb322806f9c2ab9b727463bfe5/core/session.rb#L629 calls should be removed
- looks like this code contain duplicated calls of vagrant status https://github.com/OSLL/mdbci/blob/8b5e6e911be91d6dae346ba874e5d5cb70b22319/core/session.rb#L593

History

#1 Updated by Mark Zaslavskiy over 5 years ago

  • Description updated (diff)

#2 Updated by Mark Zaslavskiy over 5 years ago

  • Sprint/Milestone changed from 0.83 to 0.9

#3 Updated by Mark Zaslavskiy almost 5 years ago

  • Sprint/Milestone changed from 0.9 to backlog

#4 Updated by Ilfat Kinyaev about 4 years ago

  • Status changed from New to Closed

Also available in: Atom PDF