Project

Profile

Help

Task #6876

Refactor boxesPlatformVersions function from https://github.com/OSLL/mdbci/blob/integration/core/session.rb

Added by Mark Zaslavskiy over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timofey Turenko
Category:
learning
Sprint/Milestone:
Start date:
07.03.2016
Due date:
% Done:

100%

Estimated time:
3:00 h
Spent time:
Target branch:
Test scenario:

Description

Problem: the function contains search + output operations, exit codes should be replaced for raise

Solution:
- divide function for
-- getBoxesPlatformVersions(boxPlatform, boxesManager) :
--- https://github.com/OSLL/mdbci/blob/649d047db152dc079e157df91e09029364192bef/core/session.rb#L741 should be refactored for exit_code=0
--- performs version collection as it implemented in boxesPlatformVersions
--- all $out.error "message"; exit_code should be replaced for raise "message"
-- showBoxesPlatformVersions():
--- extract boxPlatform, boxesManager from $session
--- pass them to getBoxesPlatformVersions
--- print results to $out

Expected result: pull request

History

#1 Updated by Mark Zaslavskiy over 4 years ago

  • Assignee changed from Kirill Krinkin to Ilfat Kinyaev

#2 Updated by Ilfat Kinyaev over 4 years ago

  • Status changed from New to Active / In progress
  • Estimated time set to 3:00 h

#3 Updated by Ilfat Kinyaev over 4 years ago

  • % Done changed from 0 to 100

#4 Updated by Ilfat Kinyaev over 4 years ago

  • Status changed from Active / In progress to Review

#5 Updated by Ilfat Kinyaev over 4 years ago

  • Assignee changed from Ilfat Kinyaev to Alexander Kaluzhny

#6 Updated by Alexander Kaluzhny over 4 years ago

  • Assignee changed from Alexander Kaluzhny to Ilfat Kinyaev

#7 Updated by Ilfat Kinyaev over 4 years ago

  • Status changed from Review to Active / In progress
  • % Done changed from 100 to 90

#8 Updated by Ilfat Kinyaev over 4 years ago

  • Status changed from Active / In progress to Review
  • Assignee changed from Ilfat Kinyaev to Alexander Kaluzhny
  • % Done changed from 90 to 100

Line deleted.

#9 Updated by Alexander Kaluzhny over 4 years ago

review done

#10 Updated by Alexander Kaluzhny over 4 years ago

  • Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy

#11 Updated by Mark Zaslavskiy over 4 years ago

Checked, need merge

#12 Updated by Mark Zaslavskiy over 4 years ago

  • Status changed from Review to Testing
  • Assignee changed from Mark Zaslavskiy to Timofey Turenko

#13 Updated by Timofey Turenko about 4 years ago

  • Status changed from Testing to Closed

no regression, closing

Also available in: Atom PDF