Task #6814
Comments from https://github.com/OSLL/mdbci/pull/109/files
Target branch:
Test scenario:
Description
Comments are related to this pull request content + Timofey comment https://github.com/OSLL/mdbci/pull/109
History
#1
Updated by Mark Zaslavskiy almost 5 years ago
- Description updated (diff)
#2
Updated by Mark Zaslavskiy almost 5 years ago
Additional Timofey comment:
6360 - там проверка invalid_states = ["not created", "poweroff"], а вот не может быть, что это не все состояния, которые возможны? не лучше ли проверять наоборот, что все ноды running ?
#3
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from New to Active / In progress
#4
Updated by Alexander Kaluzhny almost 5 years ago
#5
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from Active / In progress to Review
- Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
#6
Updated by Mark Zaslavskiy almost 5 years ago
First comment vagrant commands which were not moved to constants:
https://github.com/OSLL/mdbci/pull/109/files#diff-e5ef22ae3a44fcf52d8a5ee28558af09R412
https://github.com/OSLL/mdbci/pull/109/files#diff-e5ef22ae3a44fcf52d8a5ee28558af09R447
Second comment is not responded.
#7
Updated by Mark Zaslavskiy almost 5 years ago
- Status changed from Review to New
- Assignee changed from Mark Zaslavskiy to Alexander Kaluzhny
#8
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from New to Active / In progress
#9
Updated by Mark Zaslavskiy almost 5 years ago
- Status changed from Active / In progress to New
#10
Updated by Alexander Kaluzhny almost 5 years ago
- Estimated time set to 0:30 h
#11
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from New to Active / In progress
#12
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from Active / In progress to New
#13
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from New to Active / In progress
#14
Updated by Alexander Kaluzhny almost 5 years ago
#15
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from Active / In progress to Review
- Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
#16
Updated by Mark Zaslavskiy almost 5 years ago
- Status changed from Review to Testing
- Assignee changed from Mark Zaslavskiy to Timofey Turenko
#17
Updated by Timofey Turenko almost 5 years ago
- Status changed from Testing to Closed
no regression, closing