Task #6809
Add return codes and error messages to publicKeys method of session.rb
# Raise: "Configuration name is required"
./mdbci public_keys
# 1. Generate node
./mdbci --template confs/mdbci_up_aws_test_config.json generate SOME_DIR
# 2. Up node\nodes (NOTE: maxscale.pem must be in mdbci directory).
./mdbci up SOME_DIR
# 3. Show public keys of node\nodes.
./mdbci public_keys --key maxscale.pem SOME_DIR
./mdbci public_keys --key maxscale.pem SOME_DIR/galera0
# Raise: "No such node with name galera123 in SOME_DIR"
./mdbci public_keys --key maxscale.pem SOME_DIR/galera123
# Raise: "Keyfile not found! Check path to it!"
./mdbci public_keys --key nowhere.pem SOME_DIR
Description
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L628 #447
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L637 #456 check if nodes was found
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L640 #459 check for nil
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L649 #468 check bash exit code
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L655 #474 check for nil
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L667 #486 check bash exit code
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L670 #489 add error message and return 1 if box parameter in node configuration not found
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L677 #496 check if nodes was found
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L682 #501 check exit code
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L688 #507 check if node was found
https://github.com/OSLL/mdbci/blob/integration/core/session.rb#L694 #513 check bash exit code
Related issues
History
#1
Updated by Alexander Kaluzhny almost 5 years ago
- Related to Task #6747: Find places in app code where command line argument errors can occure and error messages should be shown. For every case create issue. added
#2
Updated by Mark Zaslavskiy almost 5 years ago
- Assignee set to Ilfat Kinyaev
#3
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from New to Active / In progress
- Estimated time set to 3:00 h
#4
Updated by Ilfat Kinyaev almost 5 years ago
- Description updated (diff)
#5
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from Active / In progress to New
#6
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from New to Active / In progress
#7
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from Active / In progress to Review
- Assignee changed from Ilfat Kinyaev to Alexander Kaluzhny
- % Done changed from 0 to 100
#8
Updated by Alexander Kaluzhny almost 5 years ago
Review done
Waiting http://maxscale-jenkins.mariadb.com:8090/job/mdbci_integration_test/ to finish
#9
Updated by Alexander Kaluzhny almost 5 years ago
#10
Updated by Alexander Kaluzhny almost 5 years ago
Jenkins tests failed
#11
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from Review to New
- Assignee changed from Alexander Kaluzhny to Ilfat Kinyaev
#12
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from New to Active / In progress
- % Done changed from 100 to 90
#13
Updated by Ilfat Kinyaev almost 5 years ago
maxscale-jenkins.mariadb.com:8090/job/mdbci_integration_test/247/ first test
#14
Updated by Ilfat Kinyaev almost 5 years ago
http://maxscale-jenkins.mariadb.com:8090/job/mdbci_integration_test/248/ second test, first test was fail
#15
Updated by Ilfat Kinyaev almost 5 years ago
http://maxscale-jenkins.mariadb.com:8090/job/mdbci_integration_test/249/ third test, second was success
#16
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from Active / In progress to Review
- Assignee changed from Ilfat Kinyaev to Alexander Kaluzhny
- % Done changed from 90 to 100
Third test was success
https://github.com/OSLL/mdbci/pull/162
#17
Updated by Alexander Kaluzhny almost 5 years ago
- Status changed from Review to New
- Assignee changed from Alexander Kaluzhny to Ilfat Kinyaev
Need raise here https://github.com/OSLL/mdbci/pull/162/files#diff-e5ef22ae3a44fcf52d8a5ee28558af09L650 if box empty.
Need raise here https://github.com/OSLL/mdbci/pull/162/files#diff-e5ef22ae3a44fcf52d8a5ee28558af09R659 if ssh command fails
#18
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from New to Active / In progress
#19
Updated by Ilfat Kinyaev almost 5 years ago
#20
Updated by Ilfat Kinyaev almost 5 years ago
#21
Updated by Ilfat Kinyaev almost 5 years ago
- Status changed from Active / In progress to Review
- Assignee changed from Ilfat Kinyaev to Alexander Kaluzhny
Last test was success.
#22
Updated by Alexander Kaluzhny almost 5 years ago
- Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
Reviewed
#23
Updated by Mark Zaslavskiy almost 5 years ago
Please provide test scenario, all other checks were passed successfuly.
#24
Updated by Mark Zaslavskiy almost 5 years ago
- Status changed from Review to New
- Assignee changed from Mark Zaslavskiy to Ilfat Kinyaev
#25
Updated by Ilfat Kinyaev over 4 years ago
- Test scenario updated (diff)
#26
Updated by Mark Zaslavskiy over 4 years ago
Please provide more details at test scenario:
- what commands should be executed
- what result should appear
#27
Updated by Ilfat Kinyaev over 4 years ago
- Status changed from New to Active / In progress
- % Done changed from 100 to 80
#28
Updated by Ilfat Kinyaev over 4 years ago
- Status changed from Active / In progress to New
#29
Updated by Ilfat Kinyaev over 4 years ago
- Status changed from New to Review
- Assignee changed from Ilfat Kinyaev to Mark Zaslavskiy
- % Done changed from 80 to 100
- Test scenario updated (diff)
#30
Updated by Mark Zaslavskiy over 4 years ago
Please fix conflicts with integration branch.
#31
Updated by Mark Zaslavskiy over 4 years ago
- Status changed from Review to New
- Assignee changed from Mark Zaslavskiy to Ilfat Kinyaev
#32
Updated by Ilfat Kinyaev over 4 years ago
https://github.com/OSLL/mdbci/pull/216
http://maxscale-jenkins.mariadb.com:8090/job/mdbci_integration_test/313/
Previous branch deleted because was unmergeable.
#33
Updated by Ilfat Kinyaev over 4 years ago
- Status changed from New to Review
- Assignee changed from Ilfat Kinyaev to Mark Zaslavskiy
#34
Updated by Mark Zaslavskiy over 4 years ago
- Assignee changed from Mark Zaslavskiy to Alexander Kaluzhny
#35
Updated by Mark Zaslavskiy over 4 years ago
- Sprint/Milestone changed from 0.83 to 0.9
#36
Updated by Alexander Kaluzhny over 4 years ago
- Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
Reviewed code. Test scenario checked with aws provider - works.
#37
Updated by Mark Zaslavskiy over 4 years ago
- Status changed from Review to Closed